Skip to content

Commit

Permalink
Remove BaseException TODO (pytorch#89540)
Browse files Browse the repository at this point in the history
After discussion in pytorch#88461 (comment)
Pull Request resolved: pytorch#89540
Approved by: https://github.com/H-Huang
  • Loading branch information
kit1980 authored and pytorchmergebot committed Nov 23, 2022
1 parent 9eed6b7 commit fa7a963
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions torch/distributed/rpc/internal.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,6 @@ def _run_function(python_udf):
if isinstance(python_udf, AttributeError):
raise python_udf
result = python_udf.func(*python_udf.args, **python_udf.kwargs)
# TODO (rohan-varma): This should probably be BaseException, but change can
# cause BC issues.
except Exception as e:
# except str = exception info + traceback string
except_str = (
Expand Down

0 comments on commit fa7a963

Please sign in to comment.