Skip to content

Commit

Permalink
Ignore LNK4099 for debug binary libtorch builds (pytorch#62060)
Browse files Browse the repository at this point in the history
Summary:
Fixes pytorch#61979

Pull Request resolved: pytorch#62060

Test Plan:
This CI shouldn't break
and pytorch#62061

Reviewed By: driazati

Differential Revision: D29877487

Pulled By: janeyx99

fbshipit-source-id: 497f84caab3f9ae609644fd397ad87a6dc8a2a77
  • Loading branch information
janeyx99 authored and facebook-github-bot committed Jul 23, 2021
1 parent 04c95a0 commit e318058
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ if(MSVC)
foreach(flag_var
CMAKE_SHARED_LINKER_FLAGS CMAKE_STATIC_LINKER_FLAGS
CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS)
string(APPEND ${flag_var} " /ignore:4049 /ignore:4217")
string(APPEND ${flag_var} " /ignore:4049 /ignore:4217 /ignore:4099")
endforeach(flag_var)

# Try harder
Expand Down
4 changes: 2 additions & 2 deletions cmake/MiscCheck.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ if(${CMAKE_CXX_COMPILER_ID} STREQUAL "MSVC")
add_definitions("/DNOMINMAX")

set(CMAKE_SHARED_LINKER_FLAGS
"${CMAKE_SHARED_LINKER_FLAGS} /ignore:4049 /ignore:4217")
"${CMAKE_SHARED_LINKER_FLAGS} /ignore:4049 /ignore:4217 /ignore:4099")
set(CMAKE_EXE_LINKER_FLAGS
"${CMAKE_EXE_LINKER_FLAGS} /ignore:4049 /ignore:4217")
"${CMAKE_EXE_LINKER_FLAGS} /ignore:4049 /ignore:4217 /ignore:4099")
endif()

# ---[ If we are building on ios, or building with opengl support, we will
Expand Down

0 comments on commit e318058

Please sign in to comment.