Added set creation from list#2822
Merged
ubaidsk merged 4 commits intolcompilers:mainfrom Mar 12, 2025
swamishiju:main
Merged
Conversation
Contributor
|
You have to get the CI to pass, currently it is failing at: |
Collaborator
Author
|
Its weird im on a Mac and |
Collaborator
|
I am observing the same issue here. Probably the CI seems to be flaky. compiler_tester.tester.RunException: Testing with reference output failed.
runtime_errors/test_assert_01.py * run_dbg
The JSON metadata differs against reference results
Reference JSON: tests/reference/run_dbg-test_assert_01-2f34744.json
Output JSON: tests/output/run_dbg-test_assert_01-2f34744.json
Omitting 9 identical items
Differing items:
{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
< File "tests/runtime_errors/test_assert_01.py", line 1
< def test():
< File "tests/runtime_errors/test_assert_01.py", line 4
< test()
< File "tests/runtime_errors/test_assert_01.py", line 2
< assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped) |
ubaidsk
reviewed
Mar 12, 2025
ubaidsk
requested changes
Mar 12, 2025
Collaborator
ubaidsk
left a comment
There was a problem hiding this comment.
Posted a comment above. Let's fix the message.
Fixed error message Co-authored-by: Mohammed Ubaid Shaikh <shaikhubaid769@gmail.com>
Collaborator
Author
|
Thank you for pointing it out, I've committed it |
ubaidsk
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for set() to accept list argument