changed format_output(...) to remove unnecessary quotation marks #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lclarkmichalek
added a commit
that referenced
this pull request
Sep 5, 2014
changed format_output(...) to remove unnecessary quotation marks
|
Thanks for this, hope it fixes that bug |
|
For german language it fixes the bug, but I'm not sure about other languages as I didn't test it - let's wait for responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe a solution for #3
As I'm using "de_DE.UTF-8" locale:
% locale -ck decimal_point
LC_NUMERIC
decimal_point=","
So the problem is, that line 241 gives a comma with quotation marks, but the desired outcome is a comma without them - so I just strip them.