Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide support button and comments consistently with claim tags #1152

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number:1146

What is the current behavior?

See #1146

What is the new behavior?

See #1146

Other information

In comment fragment for channel, the comment form visibility is GONE to avoid it been shown just before being replaced by the texto for channels having comments disabled. This change is not needed for FileViewFragment as this replacement occurs while not in user view.

Two new strings have been added. Text was taken from LBRY.TV. Translation will be needed.

This commit adds code to code which is already been duplicated in various files. This will be fixed in an upcoming PR which replaces comment form with a new widget instead of a layout which should be

@kekkyojin kekkyojin requested a review from akinwale February 24, 2021 15:11
@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Feb 24, 2021
@kekkyojin kekkyojin changed the title Hide support button and comments consistently with claim tags (Closes #1146) Hide support button and comments consistently with claim tags Feb 24, 2021
@kekkyojin
Copy link
Collaborator Author

Known problem: on content view, the text explaining that comments have been disabled by the author, wallet and rewards bubble is positioned just above it, so the string is not visible on its full length. It will fixed for #1054 very shortly.

Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor change to make before merging.

@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Feb 26, 2021
@kekkyojin kekkyojin merged commit 67b8836 into master Feb 26, 2021
@kekkyojin kekkyojin deleted the support-tags-ui-consistency branch February 26, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants