Styling <code> tag for Markdown content #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekkyojin
force-pushed
the
style-code-tag
branch
from
456da2c to
1b30865
Compare
|
I think this was missed. We intend to address PRs promptly. If it's ever longer than 1 week do not hesitate to ping us @kekkyojin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #960 -partial fix, don't close-
What is the current behavior?
<code>tag is not rendered like on LBRY Desktop or alternative websitesWhat is the new behavior?
<code>tag is now rendered like in the desktop app, both in light and dark theme.Other information
CommonMark offers the possibility of adding attributes to a node. I think this is the way it should be done, instead of embedding the CSS. This way, style is only added when needed. Code to add the style to every tag is only run when required.