Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer opening unsupported filetypes with external app #1045

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #419

What is the current behavior?

If LBRY doesn't include the capacity of showing the content on the claim, user should download file and search for it on its device and then open it

What is the new behavior?

User is shown a notice about LBRY inability to show content and a button which allows it to choose a compatible app when clicked.

Other information

This PR adds a new string and reuses other one.

In order to test it, reviewer could search for "PDF" on LBRY Android and look for one without a time on the snapshot. I used the ones with "UOC" on their title. "UOC PDF" could be a better approach for the search text.

@akinwale akinwale self-requested a review November 10, 2020 09:03
@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Nov 10, 2020
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks. I've been wanting to tackle this for a while, but I never got around to it yet.

@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Nov 13, 2020
@akinwale akinwale merged commit 896c566 into lbryio:master Nov 13, 2020
@kekkyojin kekkyojin deleted the open-file-external branch November 28, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants