Open
Conversation
Running jest runs the two test suites in parallel. If both try to run a server on port 3000, only one of them will succeed and supply files for both, however when that suite finishes first, it will take down the server and leave the other one hanging. Fix this by running the servers on different ports.
Puppeteer allows us to wait for the specific element we want to check instead of waiting for a fixed time and hoping it will be there by then. This reduces the total testing time from 26s to 7s for me.
…ing errors. This appears to have been a copy-paste error in 6b97aa2 and caused rendering of schemas that triggered such parsing errors to be aborted before anything was rendered. Also output the content that failed to parse for more info. This brings test.html output back to what is currently seen at http://lbovet.github.io/docson/tests/test.html, although with a wrongful such JSON parsing error on the console, to be fixed in the next commit.
In schemas that contained internal references ({"$ref": "#..."}), Docson would attempt to retrieve the document named by that URI using $.get(). That would result in the HTML code for the page it was running in, which is completely unrelated and would fail to parse as JSON, resulting in an error message on the console.
To avoid attempting to retrieve the root document again, initialize the document collection with it already.
As a side effect, this causes a circular reference to the root schema to be detected at the first cycle rather than the second, which makes integration test "recursive schema" fail, but actually seems desirable to me.
The previous commit causes a circular reference to the root schema to be detected at the first cycle rather than the second, like anywhere else. That actually seems to make more sense to me, so change the test that previously checked for detection at the second cycle.
It was mistakenly looked up under URI "" instead of "#".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fix several issues that became apparent in the revival of test.html, #81.
{"$ref": "#"}) not appearing in the output. This is an improvement over the “baseline” test.html output.