Skip to content

Fix failure to render a schema containing unresolvable refs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwalther wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix failure to render a schema containing unresolvable refs #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e43f7f
When a ref cannot be resolved, don't get stuck and render nothing, bu…
cwalther Sep 25, 2019
aeb3ff8
Avoid unhandled promise rejections when refs cannot be resolved.
cwalther Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,13 +404,13 @@ const highlight = false;

var refs = {};
var get_ref = function(uri) {
return new Promise( resolve => {
return new Promise( (resolve, reject) => {
get_document( uri.clone().hash('').toString() ).then(function(schema){
refs[uri.toString()] = uri.hash() ? jsonpointer.get( schema, uri.hash() ) : schema;
}).then(function(){
debug('get_ref');
resolve();
});
}, reject);
});
};

Expand Down Expand Up @@ -543,11 +543,15 @@ const highlight = false;
// use the normalized uri
parentObject.update( uri.toString() );

debug(get_ref(uri));
get_ref( uri ).finally( () => {
var refp = get_ref(uri);
debug(refp);
refp.finally( () => {
throttled_render();
resolve();
});
})
// avoid "unhandled rejection" error - the output may be redundant as the
// browser probably already logged the failure, but better be explicit
.catch(e => { console.warn("Unable to resolve $ref " + uri.toString() + ":", e); });
});
}

Expand Down