Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2485 fromdp and co2 #2486

Merged
merged 14 commits into from
May 12, 2021
Merged

Issue2485 fromdp and co2 #2486

merged 14 commits into from
May 12, 2021

Conversation

dhblum
Copy link
Contributor

@dhblum dhblum commented May 6, 2021

This is for #2485. In particular, it:

  • Changes damExh.from_dp, damRet.from_dp, damOut.from_dp all = false to revert back to what it used to be on master before MixingBox without exhaust damper #2454.
  • Adds unit test for testing solver stall with trace substances and associated reference result
  • Updates reference results for package Buildings.Examples.VAVReheat

@dhblum dhblum requested a review from mwetter May 6, 2021 22:45
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhblum Please see inline comments for minor changes.

@dhblum
Copy link
Contributor Author

dhblum commented May 10, 2021

@mwetter I'm sorry, but I don't understand why now the UTF-8 BOM check fails and how to fix it. EDIT: Also in a previous build, some tests from Buildings.ThermalZones.EnergyPlus failed. The results seemed very close to me, though there were a few points that were a little different in one or two tests, so you may just double check these to see if new reference results are acceptable to you.

@mwetter
Copy link
Member

mwetter commented May 10, 2021

@dhblum : I can update the results in Buildings.ThermalZones.EnergyPlus.
Can the simulation period in Buildings.Examples.VAVReheat.Validation.TraceSubstance be reduced to 2 days rather than 2 weeks? Currently the tests takes about 60 seconds to simulate which is long unless there is a compelling reason for such long a test.

@dhblum
Copy link
Contributor Author

dhblum commented May 10, 2021

@mwetter I reduced testing time to 2 days in 025bcad and fixed more subscripts in a5f6faf.

@mwetter mwetter merged commit d61e745 into master May 12, 2021
@mwetter mwetter deleted the issue2485_fromdpAndCO2 branch May 12, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants