Better separation of concerns when making requests. #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that this builds upon #259 and #258 so we should merge those first.)
Previously, we had
.get
and.post
, which did something like this:get
:post
:The problem with this is that neither GET nor POST what one would expect. Neither are general HTTP GET or POST utilities. They work specifically with Solr Query objects. They expect JSON responses only. They send their data as query strings only (even .post, which uses
application/x-www-form-urlencoded
).Therefore this can be much better encapsulated as:
doQuery
:doRequest
.doRequest
:This maintains a single level of abstraction per method, and therefore gives better separation of concerns and results in more understandable code. Se http://www.principles-wiki.net/principles:single_level_of_abstraction