Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solr): Add ability to inject options to the request #223

Merged
merged 4 commits into from
Dec 31, 2020

Conversation

niezgoda
Copy link
Contributor

Currently there is no ability to pass additional arguments to the http/https request.

The option to add (for example) ssl parameters (like ca, cert, key) is neccesarry in multiple cases.

Copy link
Collaborator

@julianlam julianlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert all of the whitespace changes, or re-open them into a new pull request?

@niezgoda
Copy link
Contributor Author

Can you revert all of the whitespace changes, or re-open them into a new pull request?

I have reverted all the changes to the whitespaces/formatting.

@niezgoda
Copy link
Contributor Author

Is there a way to put this on some track? :)
Thanks!

@julianlam
Copy link
Collaborator

As this is an API change (introducing a new argument to the createClient method), I would not feel comfortable merging outright, and would defer to @lbdremy

@lbdremy
Copy link
Owner

lbdremy commented Jun 15, 2020

Hello,

This change does not break the API, so no worries for me. You can merge @julianlam and publish a new minor version 0.8.0.

…into feature/ssl

� Conflicts:
�	lib/solr.js
@kibertoad kibertoad dismissed julianlam’s stale review December 31, 2020 15:10

whitespace changes were removed

@kibertoad kibertoad merged commit 84b0596 into lbdremy:master Dec 31, 2020
@kibertoad
Copy link
Collaborator

Released in 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants