chore: Upgrade proxy agent #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a merge conflict marker committed to the `package-lock.json` in cc0de4b, which coincidentally upgraded the project to use `lockfileVersion` of `2`.
In the transitive dependency [`pac-resolver` there is a known vulnerability][0]. By upgrading `proxy-agent` to latest, we're also upgrading `pac-proxy-agent` and `pac-resolver`. From reading the changelogs of `proxy-agent`, `pac-proxy-agent` and `pac-resolver`, it is clear that TooTallNate has been careful not to introduce any breaking changes, other than dropping support for old node versions. * [`proxy-agent@5.0.0`][1] * [`pac-proxy-agent@5.0.0`][2] * [`pac-resolver@5.0.0`][3] By merging this, the minimum supported node version dictated by these dependencies will be 8. [0]: GHSA-9j49-mfvp-vmhm [1]: https://github.com/TooTallNate/node-proxy-agent/releases/tag/5.0.0 [2]: https://github.com/TooTallNate/node-pac-proxy-agent/releases/tag/5.0.0 [3]: https://github.com/TooTallNate/node-pac-resolver/releases/tag/5.0.0
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
Ping @lazywithclass |
|
For those who are here because of this security issue. Here is a quick fix: add this to your package.json and this to your scripts section: |
|
Thanks for this. I will update the module this afternoon, expect a minor version change since this might break some people's setup. Again sorry for being late, I am swamped by uni courses. |
|
winston-cloudwathc@3.1.0 is out with these changes. Thanks a lot for your effort. |
|
@lazywithclass thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched from #162, which should be merged first.
This PR upgrades transitive dependencies, allowing consumers to avoid a known vulnerability.
Background
In the transitive dependency
pac-resolverthere is a known vulnerability.Solution
By upgrading
proxy-agentto latest, we're also upgradingpac-proxy-agentandpac-resolver.From reading the changelogs of
proxy-agent,pac-proxy-agentandpac-resolver, it is clear that TooTallNate has been careful not to introduce any breaking changes, other than dropping support for very old node versions.proxy-agent@5.0.0pac-proxy-agent@5.0.0pac-resolver@5.0.0Important
By merging this, the minimum supported node version dictated by these dependencies will be
8.