Return rhs in ldiv! for SVD and add a test (JuliaLang#41083)

Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
lazarusA · Jun 5, 2021 · d9d59a9 · d9d59a9
1 parent e0165b4
commit d9d59a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/stdlib/LinearAlgebra/src/svd.jl b/stdlib/LinearAlgebra/src/svd.jl
@@ -244,7 +244,8 @@ svdvals(S::SVD{<:Any,T}) where {T} = (S.S)::Vector{T}
 function ldiv!(A::SVD{T}, B::StridedVecOrMat) where T
     m, n = size(A)
     k = searchsortedlast(A.S, eps(real(T))*A.S[1], rev=true)
-    return mul!(view(B, 1:n, :), view(A.Vt, 1:k, :)', view(A.S, 1:k) .\ (view(A.U, :, 1:k)' * _cut_B(B, 1:m)))
+    mul!(view(B, 1:n, :), view(A.Vt, 1:k, :)', view(A.S, 1:k) .\ (view(A.U, :, 1:k)' * _cut_B(B, 1:m)))
+    return B
 end
 
 function inv(F::SVD{T}) where T

diff --git a/stdlib/LinearAlgebra/test/svd.jl b/stdlib/LinearAlgebra/test/svd.jl
@@ -221,6 +221,13 @@ end
     @test Uc * diagm(0=>Sc) * transpose(V) ≈ complex.(A) rtol=1e-3
 end
 
+@testset "Issue 40944. ldiV!(SVD) should update rhs" begin
+    F = svd(randn(2, 2))
+    b = randn(2)
+    x = ldiv!(F, b)
+    @test x === b
+end
+
 @testset "adjoint of SVD" begin
     n = 5
     B = randn(5, 2)