chore: clean up interfaces #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
afkbyte
reviewed
Jul 23, 2025
Collaborator
nadir-akhtar
left a comment
nadir-akhtar
left a comment
There was a problem hiding this comment.
Various comments. Also, would be excellent to turn ie. into i.e. but that's just a nice-to-have
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
nadir-akhtar
approved these changes
Jul 26, 2025
Collaborator
nadir-akhtar
left a comment
nadir-akhtar
left a comment
There was a problem hiding this comment.
LGTM -- thanks for making all the fixes!
ypatil12
merged commit 7a66480
into
release-dev/multichain-audit-fixes
15 checks passed
ypatil12
added a commit
that referenced
this pull request
Jul 29, 2025
**Motivation:** Make the interfaces clearer for integration **Modifications:** - Add integration steps for Certiificate Verification - Consistent return types for ECDSA and BN254 - Clearer documentation for making a generation reservation - Handles I-2 and I-5 audit report findings from multichain pt1 **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
nadir-akhtar
added a commit
that referenced
this pull request
Jul 30, 2025
**Motivation:** Make the interfaces clearer for integration **Modifications:** - Add integration steps for Certiificate Verification - Consistent return types for ECDSA and BN254 - Clearer documentation for making a generation reservation - Handles I-2 and I-5 audit report findings from multichain pt1 **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
ypatil12
added a commit
that referenced
this pull request
Jul 31, 2025
**Motivation:** Make the interfaces clearer for integration **Modifications:** - Add integration steps for Certiificate Verification - Consistent return types for ECDSA and BN254 - Clearer documentation for making a generation reservation - Handles I-2 and I-5 audit report findings from multichain pt1 **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
ypatil12
added a commit
that referenced
this pull request
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Make the interfaces clearer for integration
Modifications:
Result:
Clearer code