fix: multichain pt1 audit fixes #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
release-dev/multichain-audit-fixes
branch
from
55371e8 to
a3adb74
Compare
**Motivation:** Make the interfaces clearer for integration **Modifications:** - Add integration steps for Certiificate Verification - Consistent return types for ECDSA and BN254 - Clearer documentation for making a generation reservation - Handles I-2 and I-5 audit report findings from multichain pt1 **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
**Motivation:** Remove the unnecessary latest timestamp check in the `ECDSACertificateVerifier` **Modifications:** - Remove check in `getTotalStakeWeights` - Add test to confirm that certificates from older reference timestamp can be used **Result:** Clearer code
ypatil12
force-pushed
the
release-dev/multichain-audit-fixes
branch
from
6a640ef to
6e423cc
Compare
nadir-akhtar
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multichain pt1 Audit Fixes:
Medium:
Informational:
- I-02: clarify smart contract operators
- I-05: Clarify natrpsec