Skip to content

Conversation

@YadavAkhileshh
Copy link

Description

This PR fixes the incorrect WarningIcon that was displaying a checkmark instead of a warning symbol.

Changes Made

  • Updated the WarningIcon SVG path to show the correct warning triangle icon
  • The icon now displays a triangle with an exclamation mark, matching standard warning icon design

Before & After

Before: Circle with checkmark ✅ (looked like a success icon)
After: Triangle with exclamation mark ⚠️ (proper warning icon)

Issue

Fixes #1193

Testing

  • Build completed successfully
  • All tests passed

Checklist

  • Code follows project style guidelines
  • Changes are minimal and focused on the issue
  • All tests pass
  • Commit is signed off

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

… checkmark icon with the standard warning triangle icon to match design system standards.\n\nFixes layer5io#1193

Signed-off-by: YadavAkhileshh <yadavakhil2501@gmail.com>
@YadavAkhileshh
Copy link
Author

@kishore08-07 Please take a look at my PR

Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check with meshery / layer5 website with icon ? any visuals will be helpfull @YadavAkhileshh

@YadavAkhileshh
Copy link
Author

@Rajesh-Nagarajan-11 No, I didn't check the Meshery/Layer5 site. I used the standard Material-UI Warning icon SVG path since you mentioned sistent uses MUI. The path I used is the official Material Design warning triangle icon.

Should I verify it on the Meshery site first? If so, where can I find this icon being used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect WarningIcon

2 participants