feat: improve error reporting for failed user invitations (#1050) #1092
Conversation
|
Hi @zihanKuang @leecalcote |
rishiraj38
force-pushed
the
improve-invitation-error-messages
branch
from
5c6baef to
2a3b18c
Compare
|
@rishiraj38 Add it as an agenda item to the meeting minutes, if you would :) |
|
@rishiraj38 Add it as an agenda item to the meeting minutes, if you would :) |
|
@vr-varad @FaheemOnHub Apologies for missing the recent meetings — I’ve been tied up with my college exams. I truly appreciate your understanding. Also, a heartfelt thank you to @hortison for approving my very first contribution to Layers. Grateful to be part of this journey! |
| if (errorMessage.includes('email already exists')) { | ||
| handleError('Invitation failed: Email address already exists.'); | ||
| } else if (errorMessage.includes('invalid email')) { | ||
| handleError('Invitation failed: Invalid email format.'); |
There was a problem hiding this comment.
should we just display the error message instead of hardcoding it ?
It recommended not to hardcode errors , we majorly do this on backend |
rishiraj38
force-pushed
the
improve-invitation-error-messages
branch
from
2a3b18c to
1e28f7d
Compare
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
rishiraj38
force-pushed
the
improve-invitation-error-messages
branch
from
1e28f7d to
6fff8b0
Compare
|
@FaheemOnHub @Namanv0509 @hortison Please review the latest commit. |
Description
This PR improves error reporting for failed user invitations by replacing the generic error message with specific, contextual messages based on the error returned from the backend.
Changes Made
Related Issue
Closes #1050