Skip to content

Conversation

@kumarabd
Copy link
Contributor

@kumarabd kumarabd commented Aug 29, 2020

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Copy link
Contributor

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .tgz file committed by accident? Also, can we place the chart under charts directory rather than helm?
The later is just for the sake of convention, can be ignored.

@kumarabd
Copy link
Contributor Author

kumarabd commented Aug 30, 2020

Is the .tgz file committed by accident? Also, can we place the chart under charts directory rather than helm?
The later is just for the sake of convention, can be ignored.

The tgz file is the helm package-d. Im having this in the repository for now to figure out which way to install the chart with the client. Im not naming it charts because we are having content specific to technology (helm). @kushthedude

Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@kushthedude
Copy link
Contributor

The automated action need gh-page protected branch, a valid github repo admin token and a git configuration setup.
That is why I was saying to store charts in chart directory, all the automated actions follow the convention to search for charts in the chart sub-folder.

Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@leecalcote leecalcote requested a review from Aisuko August 31, 2020 01:41
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Copy link
Contributor

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@leecalcote leecalcote merged commit e6e57ec into layer5io:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants