-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: align isFullSiteBuild check to prevent silent collection exclusion #7416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: align isFullSiteBuild check to prevent silent collection exclusion #7416
Conversation
Signed-off-by: Pragalva Sapkota <pragalva.sapkota@deerwalk.edu.np>
|
🚀 Preview for commit cfc7643 at: https://698794d6f32ec9dcaefbff4a--layer5.netlify.app |
|
@PragalvaXFREZ did you check on local by building, if commands are working properly. |
|
@PragalvaXFREZ Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Hi @saurabhraghuvanshii, sorry for the late response. I did try running the build locally, but it hits the OS file watcher limit (ENOSPC) on my machine, which is unrelated to this change. It would be helpful if you could verify the commands on your end to confirm the behavior. |
|
@PragalvaXFREZ can you share screenshot for error |
Please have a look @saurabhraghuvanshii |
|
@PragalvaXFREZ which command you're using for build |
I've used |
|
@PragalvaXFREZ try |
I have ran |
|
🚀 Preview for commit 36a4d6f at: https://698d9debb7ed84e529bd45e9--layer5.netlify.app |

Description
isFullSiteBuildingatsby-config.jswithgatsby-node.jsso both default to including all collections whenBUILD_FULL_SITEis unset[] == []being false in JavaScriptProblem
gatsby-config.jsused=== "true"whilegatsby-node.jsused!== "false".When
BUILD_FULL_SITEis unset, the config excluded members/integrations from the file-system but gatsby-node still expected them, resulting in 637 pages silently missing with no error or placeholder.Notes for Reviewers
Developers using
make siteordevelop:liteare unaffected since those explicitly setBUILD_FULL_SITE=falseand will continue to get fast builds with placeholders. This change only affects the "unset" case (e.g.make site-fast), which was already broken as pages silently 404'd with no placeholders shown.Signed commits