Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve layout inconsistency in CTA_Bottom for mobile screens #5864

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: resolve layout inconsistency in CTA_Bottom for mobile screens #5864

merged 1 commit into from
Sep 13, 2024

Conversation

yash37158
Copy link
Contributor

@yash37158 yash37158 commented Sep 3, 2024 •
edited
Loading

Description
Adjusted CSS to ensure CTA_Bottom component is fully responsive

Screenshot 2024-09-04 at 1 35 00 AM

This PR fixes #5863

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@yash37158
fix: resolve layout inconsistency in CTA_Bottom for mobile screens
15411e7 
Signed-off-by: yash37158 <yash37158@gmail.com>
@l5io
Copy link
Contributor

l5io commented Sep 3, 2024

🚀 Preview for commit 15411e7 at: https://66d76f977a0869bb436280ea--layer5.netlify.app

leecalcote
leecalcote reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What other pages have you tested to ensure that this change doesn't have a negative affect?

Among others, be sure to check on the /resources articles.

@yash37158
Copy link
Contributor Author

I have reviewed the blog and resources article pages, and the changes do not have any negative impact.

@yash37158
Copy link
Contributor Author

@leecalcote @hargunkaur286 @vishalvivekm

@leecalcote
Copy link
Member

Good!

@leecalcote
Copy link
Member

I have reviewed the blog and resources article pages, and the changes do not have any negative impact.

Thanks for your diligence here.

@leecalcote leecalcote merged commit 501f598 into layer5io:master Sep 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@hargunkaur286 hargunkaur286 Awaiting requested review from hargunkaur286

Assignees
No one assigned
Labels
type/core-styls
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Flaw in CTA_Bottom Component on Mobile Screens
3 participants
@yash37158 @l5io @leecalcote