-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: responsiveness issue#5693 #5724
base: master
Are you sure you want to change the base?
Fix: responsiveness issue#5693 #5724
Conversation
Signed-off-by: Alfiya Siddique <86224794+AlfiyaSiddique@users.noreply.github.com>
Signed-off-by: Alfiya Siddique <86224794+AlfiyaSiddique@users.noreply.github.com>
197c391
to
039d787
Compare
🚀 Preview for commit 039d787 at: https://66a139ab9b9eab092ebebda6--layer5.netlify.app |
Attached a recording of the outcome, let me know if it looks good or if you have any feedback. Also, let me know about the section |
@AlfiyaSiddique This looks good to me! Can you please confirm that when we reach the related blogs section, it does become responsive once we refresh the page(after reaching the desired responsiveness), right? |
@AlfiyaSiddique There's one issue that you can solve as a part of this PR, make sure that "Layer5" starts from the next section, i.e. from below the image and is centered aligned on this page only. Below is a screenshot of the same. Let me know if it makes sense. |
@hargunkaur286 correct the |
Signed-off-by: Alfiya Siddique <86224794+AlfiyaSiddique@users.noreply.github.com>
🚀 Preview for commit 3d9b4ae at: https://66a51a7c975f4c44be977ae2--layer5.netlify.app |
Hey @hargunkaur286! |
Thank you for the contribution @AlfiyaSiddique This looks good to me! |
@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we''ll probably don't want to change site-wide css declarations @AlfiyaSiddique , as it may cause undesired behavior on other pages.
…ths <670px Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another responsiveness issue:
@AlfiyaSiddique @Ashparshp @hargunkaur286
@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid? |
✔️
Quite not. |
🚀 Preview for commit 26b2898 at: https://66a6a29cc499827ed3ad4dcd--layer5.netlify.app |
@vishalvivekm What's quite not valid, can you please describe?
The review comments are quite not clear to me so confirming! |
@hargunkaur286 we're good to go with this PR right? |
@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
🚀 Preview for commit 74d8dfa at: https://66b9f33ca3dcf17da5b486d0--layer5.netlify.app |
LGTM ! |
@AlfiyaSiddique @hargunkaur286, is there anything more to update, or is this good to go? |
@Ashparshp nothing from my side. @hargunkaur286 let me know if any more changes are needed |
Thank you @AlfiyaSiddique. |
@vishalvivekm, just a gentle reminder to review this PR when you get a chance so it can proceed further. Thanks! |
@Ashparshp is this still needed? Have you clarified the fix? |
Description
This PR fixes #5693
Notes for Reviewers
This PR contains minor style fixes for the mobile size of a section on the blog page.
Signed commits
Outcome
Recording.2024-07-24.223815.mp4