PDF translation support, and write XML using buffer #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indigo_api/exporters.py
Outdated
| @@ -205,7 +210,11 @@ def insert_frontmatter(self, document): | |||
| """ Generates the frontmatter and inserts it before the body (and coverpage if present) in the XML. | |||
| The document's document_xml isn't updated. | |||
| """ | |||
| # explicitly set the document's language for e.g. numbered title to be translated | |||
| activate(document.django_language) | |||
There was a problem hiding this comment.
rather user override() which ensures the deactivate is called if there is an error:
with override(document.django_language):
frontmatter = ...
indigo_api/exporters.py
Outdated
| with open(xml_file, "wb") as f: | ||
| f.write(xml.encode('utf-8')) | ||
| # use io.open, BytesIO, getbuffer to avoid XML parse error in production | ||
| with io.open(xml_file, "wb") as f: |
There was a problem hiding this comment.
can you link to the issue this is trying to solve? I don't see how this change will fix anything.
There was a problem hiding this comment.
longhotsummer
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.