-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision refs resolver #1832
Provision refs resolver #1832
Conversation
Do you think it's safe to make something like 'paragraph (16)' look for |
I fixed |
I want to say yes? Especially since you seem to have solved the other issues around where to look first, and finding the 'of section 2(3)' matches before their preceding 'paragraph (a)'. I suppose it does open us up to potentially more false matches, but if it's a question of just adding more elements to look for I think we can try it out and see? (rather than a big rewrite) Here are my suggestions from my test drive:
|
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
Support for synonyms, regulations and sub-regulations added. |
<subsection eId="sec_1__subsec_4"> | ||
<num>(4)</num> | ||
<content> | ||
<p>Referring to section <ref href="/akn/za/act/2009/1/~sec_26__subsec_a">26(a)</ref> of <term refersTo="#term-the_Act">the Act</term>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay we're getting fancy!
The bulk of the raised issues are fixed. I had to disable the Afrikaans translation of 'or'. I don't have a holistic fix currently for indicating to the parser which language it should be working in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor suggestions, happy for you to leave them out (especially tables) if you think it best
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
@goose-life I've added |
Replace the old internal refs resolver with a more robust provision refs resolver that can also resolve provisions in external works.
The bulk of the tests were copied over from the old resolver, especially the edge cases. We now can resolve a lot more of these than before.
A single resolver supports multiple languages, currently English and Afrikaans. Adding new languages should hopefully be relatively simple.
https://www.loom.com/share/730117beb7c048e1b857c1914ee1952e
https://www.loom.com/share/12ac35fd26ab4c07aeb850252f6f1620
Outstanding