Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick editing an attachment does not correctly generate prefixed eIds of container elements #1354

Closed
longhotsummer opened this issue Nov 17, 2021 · 2 comments · Fixed by #1355
Assignees
Labels

Comments

@longhotsummer
Copy link
Contributor

If the attachment has eId att_3, the parsed elements incorrectly have prefix att_1__.

@longhotsummer
Copy link
Contributor Author

There are two aspects to this:

  1. passing the correct id_prefix to /parse (from javascript to the server)
  2. slaw using this correctly (it currently ignores it for schedules)

@longhotsummer
Copy link
Contributor Author

We currently re-write attachment eIds (only the top-level attachment eId though) in javascript, after parsing an attachment. This means that slaw doesn't need the numbering context.

So the alternative is to re-write eids the whole way down the tree in JS after replacing an attachment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant