Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vimeo playback #149

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Fix Vimeo playback #149

merged 5 commits into from
Sep 17, 2024

Conversation

devoxin
Copy link
Member

@devoxin devoxin commented Aug 30, 2024

Fixes some 429 errors by calling Vimeo's API directly.
Unsure of limitations. You may still get blocked if your IP is associated with a data center etc etc.

freyacodes
freyacodes approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@freyacodes freyacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side-by-side testing shows that this fixes the 429 issue. The code looks good as well.

@freyacodes freyacodes merged commit 3034cd1 into main Sep 17, 2024
1 check passed
topi314 pushed a commit that referenced this pull request Sep 18, 2024
@freyacodes @topi314
Merge pull request #149 from lavalink-devs/fix/vimeo-playback
588a7a6
@topi314 topi314 deleted the fix/vimeo-playback branch September 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freyacodes freyacodes freyacodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoxin @freyacodes