Allow setting user data on tracks #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
changed the title
duncte123
reviewed
Nov 27, 2023
protocol/src/commonMain/kotlin/dev/arbjerg/lavalink/protocol/v4/player.kt
Show resolved
Hide resolved
duncte123
reviewed
Nov 27, 2023
Co-authored-by: Duncan Sterken <contact@duncte123.me>
freyacodes
requested changes
Dec 2, 2023
LavalinkServer/src/main/java/lavalink/server/player/PlayerRestHandler.kt
Show resolved
Hide resolved
|
docs are here #984 |
freyacodes
approved these changes
Dec 2, 2023
Deploying with
|
| Latest commit: |
09263d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b8c2a0c8.lavalink-bne.pages.dev |
| Branch Preview URL: | https://exp-track-user-data.lavalink-bne.pages.dev |
# Conflicts: # protocol/src/commonMain/kotlin/dev/arbjerg/lavalink/protocol/v4/player.kt
duncte123
approved these changes
Dec 2, 2023
DRSchlaubi
pushed a commit
to DRSchlaubi/Lavalink
that referenced
this pull request
Jun 23, 2024
* implement track user data * fix unit tests and add Track#copyWithUserData * remove unnecessary exceptionally * use loadItemSync instead of loadItem in player rest handler * Update protocol/src/commonTest/kotlin/PlayerSerializerTest.kt Co-authored-by: Duncan Sterken <contact@duncte123.me> * throw http 400 if both track and encodedTrack/identifier is set * add convenient deserializeUserData method for java --------- Co-authored-by: Duncan Sterken <contact@duncte123.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#984