Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement full semver spec #867

Merged
merged 4 commits into from
Apr 20, 2023
Merged

implement full semver spec #867

merged 4 commits into from
Apr 20, 2023

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Apr 20, 2023

red folks want to add a special identifier to their lavalink builds.
This requires the full semver spec which includes build metadata (+metadata)

@topi314 topi314 added this to the v3.7.6 milestone Apr 20, 2023
@topi314 topi314 self-assigned this Apr 20, 2023
freyacodes
freyacodes requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@freyacodes freyacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling it buildMetadata or BUILDMETADATA I'd just call it build, as per semver BNF:

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

freyacodes
freyacodes reviewed Apr 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@topi314 topi314 requested a review from freyacodes April 20, 2023 15:55
freyacodes
freyacodes reviewed Apr 20, 2023
View reviewed changes
IMPLEMENTATION.md Outdated Show resolved Hide resolved
@topi314 @freyacodes
Update IMPLEMENTATION.md
262506d 
Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
@freyacodes freyacodes merged commit 8032e3c into dev Apr 20, 2023
@freyacodes freyacodes deleted the full-semver-spec branch April 20, 2023 20:36
@Jackenmen Jackenmen mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freyacodes freyacodes freyacodes approved these changes

@devoxin devoxin Awaiting requested review from devoxin

Assignees

@topi314 topi314

Labels
enhancement
Projects
None yet
Milestone
v3.7.6
Development

Successfully merging this pull request may close these issues.
2 participants
@topi314 @freyacodes