Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lavalink sessions for plugins #1042

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Apr 27, 2024

This pr adds the ability for plugins to easily access the sessions without having to import the lavalink server as a dependency

in some plugins i want to have rest routes such as /v4/sessions/{SESSION_ID}/players/{GUILD_ID}

this is rather annoying atm since you have to add the lavalink server as a compile only dependency

@topi314 topi314 self-assigned this Apr 27, 2024
@topi314
Copy link
Member Author

topi314 commented Apr 27, 2024

two such example plugins would be https://github.com/topi314/LavaLyrics or https://github.com/topi314/LavaQueue

Copy link
Member

@devoxin devoxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topi314 topi314 force-pushed the feature/expose-sessions-to-plugins branch from ac20e08 to a483714 Compare April 27, 2024 21:00
Copy link
Member

@freyacodes freyacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good way to implement this. However, it lacks documentation.

@topi314 topi314 force-pushed the feature/expose-sessions-to-plugins branch from a483714 to 4127f24 Compare April 28, 2024 09:52
@topi314 topi314 merged commit 78c090c into dev Apr 28, 2024
2 checks passed
@topi314 topi314 deleted the feature/expose-sessions-to-plugins branch April 28, 2024 09:58
DRSchlaubi pushed a commit to DRSchlaubi/Lavalink that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants