Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ongaku to the client.md list. #1017

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Adding ongaku to the client.md list. #1017

merged 3 commits into from
Mar 2, 2024

Conversation

mplatypus
Copy link
Contributor

Adding my client to the list of clients on the Lavalink website.

Copy link
Member

@freyacodes freyacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this library should be listed further up with the other purely Python libraries?

@mplatypus
Copy link
Contributor Author

oh yeah sorry, didn't know how it was ordered 😅

Copy link
Contributor Author

@mplatypus mplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am doing this right, this should? have my fix, however, I am unsure.

Edit: I have no idea how to get my changed version of this into this pr sorry. I did move it down so it was alphabetical, however, I cannot figure out how to get it to show up here.

@freyacodes
Copy link
Member

I am as confused as you are. It looks like you pushed to the correct branch in your fork, but it isn't reflecting here.

@topi314
Copy link
Member

topi314 commented Mar 1, 2024

https://www.githubstatus.com/

Update - We're investigating issues with background jobs that are causing sporadic delays in pull request synchronization and reduced Actions throughput.

@mplatypus
Copy link
Contributor Author

lmao, what a coincidence. I even googled to make sure I was doing the right thing, and it's a github issue xD

@topi314
Copy link
Member

topi314 commented Mar 1, 2024

on that note: you should move it to the bottom of the python clients

@mplatypus
Copy link
Contributor Author

I'll be able to do that tomorrow if I do remember. Otherwise, you are more than welcome to move it and merge the branch as you please.

@mplatypus
Copy link
Contributor Author

okay, I have re-updated it to add mine at the bottom of the python list.

@topi314 topi314 merged commit c70ee6a into lavalink-devs:master Mar 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants