Cleanup plugin loading code #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
requested changes
Feb 6, 2024
LavalinkServer/src/main/java/lavalink/server/bootstrap/PluginManager.kt
Outdated
Show resolved
Hide resolved
…anager.kt Co-authored-by: Toπ <git@topi.wtf>
topi314
approved these changes
Feb 6, 2024
Merged
DRSchlaubi
pushed a commit
to DRSchlaubi/Lavalink
that referenced
this pull request
Jun 23, 2024
* cleanup code * apply feedback * don't iterate jars twice * Update LavalinkServer/src/main/java/lavalink/server/bootstrap/PluginManager.kt Co-authored-by: Toπ <git@topi.wtf> * remove stray `")` --------- Co-authored-by: Toπ <git@topi.wtf>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to refactor the code for loading plugins as it's a little un-kotlin-like currently and a bit messy.