Skip to content

Conversation

@szc321
Copy link

@szc321 szc321 commented Jun 6, 2023

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321 szc321 closed this Jun 6, 2023
@szc321 szc321 reopened this Jun 6, 2023
@szc321 szc321 force-pushed the fix_static_analysis branch 3 times, most recently from 28378e7 to ab2e144 Compare June 6, 2023 09:55
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321 szc321 force-pushed the fix_static_analysis branch from ab2e144 to 552f296 Compare June 7, 2023 02:07
@killight98 killight98 self-requested a review June 7, 2023 04:13
@killight98 killight98 merged commit 76227f0 into lava-nc:messaging_refactor_release2nd Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants