Skip to content

Conversation

@hongdami
Copy link

@hongdami hongdami commented Aug 11, 2022

  1. Move csrc to message_infrastructure/csrc
  2. Modify CMakeLists.txt and *_py_wrapper.cc to enable build first
  3. Update ci-build.yml

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

1. Move csrc to message_infrastructure/csrc
2. Modify CMakeLists.txt and *_py_wrapper.cc to enable build first
3. Update ci-build.yml
@hongdami hongdami requested review from hexu33 and killight98 August 11, 2022 12:26
@hongdami hongdami merged commit d41e412 into lava-nc:messaging_refactor_develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants