Add TSBlock #1
Merged
Add TSBlock #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the TsBlock abstraction for batched time-series data, integrates it into the session data flow, and extends the buffer utilities.
- Implemented
TsBlockclass withDeserializesupport and new column decoders - Added
RpcDataSetfor RPC-based query result handling and updatedSessionDataSet - Extended
ByteBufferwith aGetBytesbyLengthhelper and updatedSessionPoolvariable naming
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Apache.IoTDB/SessionPool.cs | Renamed local dataset variable |
| src/Apache.IoTDB/DataStructure/TsBlock.cs | Added TsBlock and deserialization logic |
| src/Apache.IoTDB/DataStructure/SessionDataSet.cs | Introduced unused _rpcDataSet field and formatting changes |
| src/Apache.IoTDB/DataStructure/RpcDataSet.cs | New RPC dataset handling class |
| src/Apache.IoTDB/DataStructure/Column_decoder.cs | Added column decoder framework |
| src/Apache.IoTDB/DataStructure/ByteBuffer.cs | Added GetBytesbyLength method |
Comments suppressed due to low confidence (3)
src/Apache.IoTDB/SessionPool.cs:713
- Local variable 'SessionDataSet' should use camelCase (e.g., 'sessionDataSet') to avoid confusion with the class name.
var SessionDataSet = await ExecuteQueryStatementAsync(sql);
src/Apache.IoTDB/DataStructure/ByteBuffer.cs:149
- [nitpick] Method name 'GetBytesbyLength' should use consistent PascalCase ('GetBytesByLength') to align with .NET naming conventions.
public byte[] GetBytesbyLength(int length)
src/Apache.IoTDB/DataStructure/TsBlock.cs:24
- Consider adding unit tests for TsBlock.Deserialize (and related decoders) to verify correct deserialization of various data types and encodings.
public static TsBlock Deserialize(ByteBuffer reader)
| Close().Wait(); | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
After fetching new results, the response payload is never assigned to '_queryResult'; you should update '_queryResult' with the new data (e.g., ' _queryResult = resp.ResultsList') before resetting the index.
Suggested change
| _queryResult = resp.ResultsList; |
Copilot uses AI. Check for mistakes.
lausannel
commented
May 24, 2025
lausannel
commented
Jun 25, 2025
| @@ -454,8 +453,7 @@ public async Task TestInsertAlignedStringRecordsOfOneDevice() | |||
| System.Diagnostics.Debug.Assert(status == 0); | |||
| var res = await session_pool.ExecuteQueryStatementAsync( | |||
| "select * from " + string.Format("{0}.{1}", testDatabaseName, testDevice) + " where time<10"); | |||
| res.ShowTableNames(); | |||
| while (res.HasNext()) Console.WriteLine(res.Next()); | |||
| UtilsTest.PrintDataSet2(res); | |||
There was a problem hiding this comment.
分别改成PrintDatasetByType、PrintDatasetByObject、PrintDatasetByString
| { | ||
| res.Next(); | ||
| Console.WriteLine(res.GetRow()); |
| @@ -54,8 +54,7 @@ public async Task TestInsertAlignedTablet() | |||
| System.Diagnostics.Debug.Assert(status == 0); | |||
| var res = await session_pool.ExecuteQueryStatementAsync( | |||
| "select * from " + string.Format("{0}.{1}", testDatabaseName, testDevice) + " where time<15"); | |||
| res.ShowTableNames(); | |||
| while (res.HasNext()) Console.WriteLine(res.Next()); | |||
| UtilsTest.PrintDataSet2(res); | |||
| @@ -307,8 +305,7 @@ public async Task TestTestInsertTablets() | |||
| // System.Diagnostics.Debug.Assert(status == 0); | |||
| var res = await session_pool.ExecuteQueryStatementAsync( | |||
| "select * from " + string.Format("{0}.{1}", testDatabaseName, testDevices[1]) + " where time<15"); | |||
| res.ShowTableNames(); | |||
| while (res.HasNext()) Console.WriteLine(res.Next()); | |||
| UtilsTest.PrintDataSet2(res); | |||
| { | ||
| res.Next(); | ||
| Console.WriteLine(res.GetRow()); |
| @@ -324,8 +324,7 @@ public async Task TestDeleteData() | |||
| System.Diagnostics.Debug.Assert(status == 0); | |||
| var res = await session_pool.ExecuteQueryStatementAsync( | |||
| "select * from " + string.Format("{0}.{1}", testDatabaseName, testDevice) + " where time<10"); | |||
| res.ShowTableNames(); | |||
| while (res.HasNext()) Console.WriteLine(res.Next()); | |||
| UtilsTest.PrintDataSet2(res); | |||
| @@ -336,8 +335,7 @@ public async Task TestDeleteData() | |||
| await session_pool.DeleteDataAsync(ts_path_lst, 2, 3); | |||
| res = await session_pool.ExecuteQueryStatementAsync( | |||
| "select * from " + string.Format("{0}.{1}", testDatabaseName, testDevice) + " where time<10"); | |||
| res.ShowTableNames(); | |||
| while (res.HasNext()) Console.WriteLine(res.Next()); | |||
| UtilsTest.PrintDataSet2(res); | |||
| res.ShowTableNames(); | ||
| while (res.HasNext()) Console.WriteLine(res.Next()); | ||
|
|
||
| UtilsTest.PrintDataSet2(res); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.