Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low-hanging fruit from the R repository #106

Merged
merged 15 commits into from
Aug 16, 2024
Merged

Low-hanging fruit from the R repository #106

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6f09108
Plug a memory leak in `tre_match()`.
dag-erling Jul 25, 2024
3893abc
Make `num_submatches` unsigned.
dag-erling Jul 25, 2024
793049e
Make `num_tags` unsigned.
dag-erling Jul 25, 2024
577ec41
Fix potential buffer overflow in macro expansion.
dag-erling Jul 25, 2024
64b64f1
Fix `xafree()` macro.
dag-erling Jul 25, 2024
8837a3a
Assert a non-null result.
dag-erling Jul 25, 2024
1e3f327
Cosmetic fixes.
dag-erling Jul 25, 2024
fd1e5c8
Fix pointer hash function.
dag-erling Jul 25, 2024
a02216c
Raise warning level.
dag-erling Jul 25, 2024
5142407
Drop unused function arguments.
dag-erling Jul 25, 2024
f54c02b
Fix dynamic narrow mode.
dag-erling Jul 25, 2024
89d0022
Fix some type issues.
dag-erling Jul 25, 2024
f7bd6de
Work around a bug in Windows.
dag-erling Jul 25, 2024
e040f61
Remove pointless defines.
dag-erling Jul 26, 2024
b6d3254
Fully copy literal nodes.
dag-erling Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix potential buffer overflow in macro expansion. 
Obtained from the R repository.
  • Loading branch information
@dag-erling
dag-erling committed Jul 30, 2024
commit 577ec412f342143c2103f71fb513952db8e99383
2 changes: 1 addition & 1 deletion lib/tre-parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ tre_expand_macro(const tre_char_t *regex, const tre_char_t *regex_end,
unsigned int j;
DPRINT(("Expanding macro '%c' => '%s'\n",
tre_macros[i].c, tre_macros[i].expansion));
for (j = 0; tre_macros[i].expansion[j] && j < buf_len; j++)
for (j = 0; tre_macros[i].expansion[j] && j < buf_len - 1; j++)
buf[j] = tre_macros[i].expansion[j];
buf[j] = 0;
break;
Expand Down