ci: promote nullable diagnostics to warning severity (INFRA-003)

[laurentiu021]

Summary

• Promoted CS8600/CS8602/CS8603/CS8625 from suggestion to warning in .editorconfig
• Combined with TreatWarningsAsErrors from INFRA-001, these are now compile errors
• Fixed 2 nullable dereferences in integration tests (Application.Current?.Resources)

Test plan

• CI build passes (all projects compile cleanly)
• Unit tests pass
• No nullable warnings remain

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR strengthens nullability safety by elevating C# nullability diagnostics to warnings in the EditorConfig, and adds defensive null-conditional operators to resource dictionary loading in UI test helpers to prevent potential null reference exceptions.

Changes

Nullability Safety Improvements

Layer / File(s)	Summary
EditorConfig nullability diagnostic severity .editorconfig	C# nullability diagnostics CS8600, CS8602, CS8603, and CS8625 are promoted from suggestion to warning severity to align with error promotion behavior.
Test resource dictionary null-conditional operators SysManager/SysManager.IntegrationTests/AboutViewUiTests.cs, SysManager/SysManager.IntegrationTests/DeepCleanupViewUiTests.cs	Both test files add null-conditional operators to Application.Current?.Resources.MergedDictionaries.Add() calls to safely handle cases where Application.Current may be null during STA-thread resource initialization.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 With whiskers twitching and ears held high,
We catch those nulls before they fly!
From suggestion to warning we proclaim,
Safe resource binding—no null to blame! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: promoting nullable diagnostics to warning severity in the editorconfig file. It clearly summarizes the primary objective of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/editorconfig-nullable-warnings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

SysManager/SysManager.IntegrationTests/DeepCleanupViewUiTests.cs (1)

80-86: 💤 Low value

Consider storing the application instance for more explicit resource merging.

Same pattern as AboutViewUiTests.cs: the null-conditional operator correctly satisfies the nullability diagnostic, but storing the created application instance would be clearer:

var app = new System.Windows.Application
{
    ShutdownMode = ShutdownMode.OnExplicitShutdown
};
var uri = new Uri("pack://application:,,,/SysManager;component/App.xaml", UriKind.Absolute);
var dict = (ResourceDictionary)Application.LoadComponent(uri);
app.Resources.MergedDictionaries.Add(dict);

This approach avoids the nullability concern entirely and makes the intent more explicit.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@SysManager/SysManager.IntegrationTests/DeepCleanupViewUiTests.cs` around
lines 80 - 86, Store the created System.Windows.Application instance in a local
variable (e.g., app) instead of relying on Application.Current so you can
explicitly merge resources: create the application with ShutdownMode =
ShutdownMode.OnExplicitShutdown, call Application.LoadComponent to get the
ResourceDictionary (dict), then call app.Resources.MergedDictionaries.Add(dict)
(replacing the Application.Current?.Resources.MergedDictionaries.Add(dict)
pattern); this mirrors the approach used in AboutViewUiTests.cs and removes the
null-conditional usage.

SysManager/SysManager.IntegrationTests/AboutViewUiTests.cs (1)

86-93: 💤 Low value

Consider storing the application instance for more explicit resource merging.

The null-conditional operator correctly satisfies the nullability diagnostic, but you could make the intent clearer by storing the created application instance and using it directly:

var app = new System.Windows.Application
{
    ShutdownMode = ShutdownMode.OnExplicitShutdown
};
// Merge App resources so styles defined at app scope are available.
var uri = new Uri("pack://application:,,,/SysManager;component/App.xaml", UriKind.Absolute);
var dict = (ResourceDictionary)Application.LoadComponent(uri);
app.Resources.MergedDictionaries.Add(dict);

This avoids the nullability concern entirely and makes it explicit that you're using the newly created instance.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@SysManager/SysManager.IntegrationTests/AboutViewUiTests.cs` around lines 86 -
93, The current code creates a new System.Windows.Application but merges
resources via Application.Current with a null-conditional; instead explicitly
store the created instance (e.g., var app = new System.Windows.Application {
ShutdownMode = ShutdownMode.OnExplicitShutdown }) and call
app.Resources.MergedDictionaries.Add(dict) after obtaining dict from
Application.LoadComponent(uri), so the merge targets the known instance rather
than relying on Application.Current.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@SysManager/SysManager.IntegrationTests/AboutViewUiTests.cs`:
- Around line 86-93: The current code creates a new System.Windows.Application
but merges resources via Application.Current with a null-conditional; instead
explicitly store the created instance (e.g., var app = new
System.Windows.Application { ShutdownMode = ShutdownMode.OnExplicitShutdown })
and call app.Resources.MergedDictionaries.Add(dict) after obtaining dict from
Application.LoadComponent(uri), so the merge targets the known instance rather
than relying on Application.Current.

In `@SysManager/SysManager.IntegrationTests/DeepCleanupViewUiTests.cs`:
- Around line 80-86: Store the created System.Windows.Application instance in a
local variable (e.g., app) instead of relying on Application.Current so you can
explicitly merge resources: create the application with ShutdownMode =
ShutdownMode.OnExplicitShutdown, call Application.LoadComponent to get the
ResourceDictionary (dict), then call app.Resources.MergedDictionaries.Add(dict)
(replacing the Application.Current?.Resources.MergedDictionaries.Add(dict)
pattern); this mirrors the approach used in AboutViewUiTests.cs and removes the
null-conditional usage.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ca512625-1d83-41ee-9764-cbcf3fdbf13f

📥 Commits

Reviewing files that changed from the base of the PR and between a31100a and 7b3f64e.

📒 Files selected for processing (3)

• .editorconfig
• SysManager/SysManager.IntegrationTests/AboutViewUiTests.cs
• SysManager/SysManager.IntegrationTests/DeepCleanupViewUiTests.cs

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build & unit tests
• GitHub Check: Analyze (csharp)

🔇 Additional comments (1)

.editorconfig (1)

121-125: LGTM!