Skip to content

[Enhancement]: Security — UninstallerService registry validation, EventLog XPath, LogService path sanitization #319

Description

@laurentiu021

Problems

  1. UninstallerService — Registry UninstallString executed with minimal validation. HKCU can be modified without admin (SEC-002)
  2. EventLogService — XPath sanitization only strips single quotes, other metacharacters not handled (SEC-003)
  3. LogService — Path sanitization regex only covers C: drive (SEC-004)

Review IDs: SEC-002 to SEC-004 (MEDIUM/LOW)

Activity

  1. coderabbitai commented on May 13, 2026

    @coderabbitai
    🔗 Related PRs

    #249 - fix: address code review findings (QA, security, thread-safety) [merged]
    #284 - feat: uninstaller local app support via registry UninstallString [merged]
    #300 - fix: address 3 medium-priority findings (SEC-005, PERF-008, TEST-008) [closed]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecuritySecurity issue

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions