[Enhancement]: Notification Blocker — replace "master switch", and "whitelist" in comments and test names #2617

Activity

1. laurentiu021

   added

   enhancementNew feature or requestNew feature or request

   on Oct 8, 2026
2. laurentiu021

   closed this as completedin #2657on Oct 9, 2026
3. laurentiu021 commented on Oct 9, 2026

   

   laurentiu021

   on Oct 9, 2026

   OwnerAuthor

   More actions

   Fixed in v1.128.3 (#2657).

   Cause. An earlier pass removed these words by hand in 0.48.22, and nothing kept them out afterwards: they came back with the maintenance scheduler in 1.50.0, whose fixed arguments were "whitelisted", and with Notification Blocker in 1.56.0, whose top toggle was "the master switch" on screen, in its confirmation, on the status line and in the README, and in the comments, log messages, identifiers and test names behind it.

   Fix. The toggle is the main switch everywhere it is named: MasterEnabled became AllowNotifications, after the caption beside it, and the view binds to it; ReadMasterToggleWriteCount became ReadMainToggleWriteCount; the log lines say main toggle, or name ToastEnabled where reading or writing that value is denied. The scheduler's arguments are an allowlist, test names included, and the one use in the changelog's history now says main switch. What the switch does is unchanged. As proposed, notification-master-writes.json keeps its name, so the count on PCs that have one is not lost, and SetMasterVolume and its relatives stay, as Windows API names.

   Guard. InclusiveTermsTests reads every text file in the repository's top folder, .github, docs and the solution, and fails on a non-inclusive term. The only uses it allows are those API names, that file name, and winget-pkgs' own branch in the README link and the release steps. Against the unfixed tree it failed on 103 lines in 18 files; it passes over 978 files now, and each of eight mutations of it, or of a file it reads, turns a named test red.

   Files. ViewModels/NotificationBlockerViewModel.cs, Views/NotificationBlockerView.xaml, Services/NotificationBlockerService.cs, Services/GamingTweaks.cs, Services/GamingProfileService.cs, Models/GamingProfile.cs, Models/MaintenanceSchedule.cs, Services/MaintenanceSchedulerService.cs, Services/IAudioMixerService.cs, their tests, the new InclusiveTermsTests, README, ARCHITECTURE, CONTRIBUTING and CHANGELOG.