Mobile: Fixes #7918: Use react-native-drawer-layout instead of react-native-side-menu-updated #7953
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Not really sure why this is happening, but for some reason if it's set to "onChange", then editing the title of a note makes the drawer pop out again. Very strange.
|
I don't have an iOS device to test with but if this issue also occurs on it, perhaps it'd be better to use a more recently updated library like react-native-drawer-layout? |
|
Yes, if you can make it work with a more recent library that would be great. Some of the RN libs we use are very old and no longer maintained |
|
Ok I've replaced the library instead @laurent22, can confirm it's working well on Android. Although, somebody with an iOS environment needs to test how it works on iOS and update pods, too. |
jcgurango
changed the title
…gurango/joplin into feature/drawer-layout-android
|
CI is failing. You need to run |
|
@laurent22 are you able to build the latest from dev? I seem to be getting this from the metro bundler: Edit: Hmm might be an issue with my branch, not getting it with current upstream/dev |
|
That looks good @jcgurango. Would you mind fixing the conflicts so that we can merge? |
|
Updated @laurent22 |
|
Thanks! |
There is currently a bug on Android on Samsung Galaxy S21 and S22 phones where you can't use the swipe gesture to open the menu. I have not been able to confirm on any other devices whether or not this is an issue, but I tracked it down and the issue seems to be related to how the library react-native-side-menu-updated handles the gesture. I don't have any further information than that, but simply replacing the side menu with DrawerLayoutAndroid on Android devices seems to fix the issue.
Related issue: #7918