Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Font Library to FontAwesome #3138

Closed
wants to merge 3 commits into from
Closed

Changing Font Library to FontAwesome #3138

wants to merge 3 commits into from

Conversation

glitchedgitz
Copy link

Issue #3137

I implemented Font Awesome font library and removed previous font library which was Fork Awesome.

Changes Made in files are simple

  1. Changing path of forkawesome to fontawesome in index.html
  2. In rest of files changes syntax, names and classes of icons.

How to use Font Awesome
Simple just as fork awesome
This is the syntax <i class="fas fa-search">
To understand more I would recommend w3school's link https://www.w3schools.com/icons/fontawesome5_intro.asp

Note: I did check for License and all the icons I used are available for free and are under License
In future Whenever using new icons from fontawesome, one have to check here https://fontawesome.com/icons?d=gallery&m=free and search for that icon, if it is available then you can use it without issue

Joplin's Screenshot with these changed icons
fontawesome
Screenshot (122)

Added Files
ElectronClient/css/LICENSE.txt
ElectronClient/css/fontawesome.min.css

Deleted Files
ElectronClient/css/fork-awesome.min.css
ElectronClient/fonts/forkawesome-webfont.woff2

Modified Files
ElectronClient/gui/ConfigMenuBar.jsx
ElectronClient/gui/ConfigScreen.jsx
ElectronClient/gui/Header.jsx
ElectronClient/gui/HelpButton.jsx
ElectronClient/gui/IconButton.jsx
ElectronClient/gui/MainScreen.jsx
ElectronClient/gui/NoteList.jsx
ElectronClient/gui/NotePropertiesDialog.jsx
ElectronClient/gui/NoteRevisionViewer.jsx
ElectronClient/gui/NoteSearchBar.jsx
ElectronClient/gui/NoteText.jsx
ElectronClient/gui/ShareNoteDialog.tsx
ElectronClient/gui/SideBar.jsx
ElectronClient/gui/ToolbarButton.jsx
ElectronClient/gui/editors/TinyMCE.tsx
ElectronClient/index.html
ReactNativeClient/lib/models/Setting.js

PS: This is my first Pull Request So please let me If I do any mistake

@tessus
Copy link
Collaborator

tessus commented Apr 27, 2020

I don't think that changing to FontAwesome is a good idea. There was some license issue a while back. I think Laurent might know more about it.

@glitchedgitz
Copy link
Author

@tessus, I recently checked for license and Font Awesome 5 have two versions( free and pro ), free version contains mostly all the icons and we can use it for any purpose(even commercial)

Please check it here https://fontawesome.com/license/free and Let me know if I missed something.

And why we should shift to Font Awesome 5, I explained it here https://discourse.joplinapp.org/t/using-font-awesome-lib-for-icons/8222

@glitchedgitz
Copy link
Author

@PackElend Please label this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants