Desktop: Correct numbering of list items when indenting/outdenting #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkuu
changed the title
|
Sorry @sinkuu, again there's a conflict on NoteText.jsx, please could you have a look at it? Again I expect it's a matter of moving the code to AceEditor.tsx. |
sinkuu
force-pushed
the
correct_numbered_list
branch
from
6a9608a
to
0a632b1
Compare
sinkuu
force-pushed
the
correct_numbered_list
branch
from
7e8f1f1
to
b3580f9
Compare
|
I think there's an issue with the way it numbers the items at the moment. If I start from this:
and I indent the third item, it is correctly re-numbered "1", but the next one is till "4", while it should be "3":
Also if I try to indent two items it doesn't re-number them:
|
|
Closing inactive pull request for now. If you'd like to work on it again @sinkuu, feel free to let me know and thanks for your work so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue pointed out by @tessus: #2713 (comment)
When (Shift+)Tab key is pressed, the editor will try finding out the numbered list item with the current indent level + 1 (or - 1 if Shift+Tab) and sets the current line's number accordingly.