Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: fix window dimensions and position when the application start #2514

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Desktop: fix window dimensions and position when the application start #2514

merged 5 commits into from
Feb 27, 2020

Commits on Feb 23, 2020

  1. ElectronClient window minimum size set

    Hardcoded minimum width and height of 100 px.
    
    Signed-off-by: daukadolt <daulet.amirkhanov.official@gmail.com>
    daukadolt committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    3110f31 View commit details
    Browse the repository at this point in the history
  2. Set Electron window position if outside displays

    Set Electron window at the center of primaryDisplay if BrowserWindow is not on any displays.
    
    Signed-off-by: daukadolt <daulet.amirkhanov.official@gmail.com>
    daukadolt committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    29df6fc View commit details
    Browse the repository at this point in the history
  3. Set Electron window default size dependent on screen

    Set Electron window defaultWidth, defaultHeight to 80% of primary display workArea width, height, respectively.
    
    Signed-off-by: daukadolt <daulet.amirkhanov.official@gmail.com>
    daukadolt committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    9081867 View commit details
    Browse the repository at this point in the history
  4. Hotfixing Electron defaultHeight depending on width, not height

    Hotfix of a typo that calculates Electron app's default height at first run using primary screen's width, not height.
    
    Signed-off-by: daukadolt <daulet.amirkhanov.official@gmail.com>
    daukadolt committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    de7a510 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Refactoring Electron app defaultWidth/defaultHeight setup

    Setting defaultWidth/defaultHeight directly without extra variables.
    Rounding defaultWidth/defaultHeight.
    
    Signed-off-by: daukadolt <daulet.amirkhanov.official@gmail.com>
    daukadolt committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b9e3287 View commit details
    Browse the repository at this point in the history