-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add katex font KaTeX_Size4-Regular.woff2 #2478
Conversation
I forgot to actually mention you @laurent22 Not sure, if you turned off all notifications. |
@laurent22 I still think we should add all |
f1f67e8
to
ad57ffe
Compare
Yes, maybe, but is there any doc about what these extra fonts are for? We had the same four for a long time and it seems it's good enough, so I get the feeling the other ones aren't really needed for us. |
The extra font you've added also needs to be registered in katex.js. We don't load all the assets every time, only those relevant to the active plugins within the note, and so plugins need to tell the app what assets they need. That makes me think that could actually be automated, but for now we need to do that manually. |
Ok, I've registered the font in I've also opened an issue with katex to ask for a list/matrix of what the fonts are used for. I suspect they are just used for different aspects of KaTeX. e.g. if you use a function x,y,z, font A is used, and so on. |
@laurent22 this one should also be ready. btw, I've added comments to make adding other fonts easier in the future. You will only have to uncomment the fonts and done. |
Hmm, yes that's a good point. I've also made some tests and I see that while having the fonts there would increase the package size, it shouldn't affect performances. So I'm ok with including all the fonts as you've prepared in the build script. If you could uncomment the code, we can merge this. |
@laurent22 done |
Perfect, thanks! |
fixes #2477
Laurent, I think we should add all
*.woff2
fonts.