Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix inconsistency when pasting text #2431

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

miciasto
Copy link
Contributor

@miciasto miciasto commented Feb 3, 2020

There are two methods for pasting text into a note:

  1. Ctrl+V
  2. Right-click -> Paste

However the two methods end up in a different state after the paste. They should be the same.

Ctrl+V: the mark is moved to the end of the newly inserted text, as expected.

Right-click -> Paste: the newly inserted text is selected

The behaviour for Ctrl+V is correct. This PR modifies the behaviour of Right-click -> Paste to match Ctrl+V.

Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tessus tessus added the desktop All desktop platforms label Feb 3, 2020
@laurent22
Copy link
Owner

Looks good, but there's one conflict. Once it's fixed we can merge.

@miciasto
Copy link
Contributor Author

miciasto commented Feb 6, 2020

but there's one conflict

Resolved!

@tessus
Copy link
Collaborator

tessus commented Feb 6, 2020

Thanks for the update. Since Laurent already mentioned this could be merged after resolving the conflict, I'm merging.... ;-)

@miciasto
Copy link
Contributor Author

miciasto commented Feb 6, 2020

Thanks @tessus

@tessus tessus merged commit b15b3d6 into laurent22:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants