Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Fix Goto scrolling (#2122) #2199

Merged
merged 3 commits into from
Dec 28, 2019
Merged

Desktop: Fix Goto scrolling (#2122) #2199

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edf3e07
Fix Goto scrolling (#2122)
rc2dev Dec 18, 2019
62674dc
Better fix to Goto scrolling (#2122)
rc2dev Dec 18, 2019
425d0fe
Fix #2122: fix bottomItemIndex and top values
rc2dev Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ElectronClient/app/gui/ItemList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ class ItemList extends React.Component {

makeItemIndexVisible(itemIndex) {
const top = Math.min(this.props.items.length - 1, this.state.topItemIndex + 1);
const bottom = Math.max(0, this.state.bottomItemIndex);

if (itemIndex >= top && itemIndex <= bottom) return;

let scrollTop = 0;
if (itemIndex < top) {
Expand Down