-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Prevent horizontal scrolling on Linux when a scrollbar is present in note list #2062
Conversation
This is interesting, I have never seen this behavior on macOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In general we simply don't want the list to scroll horizontally regardless of the content. In that case, couldn't we just set |
I had tried the overflow-x but it did not seem to work for this case. This way you get both the width and max-width in the CSS. The width, it appears, is being pulled from the parent container which is fine until the scrollbar appears and for some reason the Linux version doesn't like this. This is where the max-width comes in and overrides the width since the note list container now has a scrollbar that is taking up space that was not in the original assessment of the width. |
Thanks for clarifying. This change seems more like a hack to go around a bug in Chrome Linux. As such please could you add the following?
Also please could you rename the property to 'maxWidth' and check that it still works? I think this is the correct case for this property. |
I apologize, I missed the maxWidth case on the initial commit but I had it locally after the fact. First time for me so let me know if I need to change anything else! |
Perfect, thanks for the update @boring10, it's good to merge now. |
…when a scrollbar is present in note list (laurent22#2062) * Prevent horizontal scrolling on Linux when a scrollbar is present in the note list. * max-width usage specifically to target Linux horizontal scroll problem.
Bug fix for #1570.
Before the fix:
After the fix: