Desktop: hide some toolbar buttons when editor hidden #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses issue: laurent22#1896
|
Nice and simple solution, thanks @nathanleiby. I'll test to double-check but most likely it's good to merge. |
|
@nathanleiby btw, if one of your commits fixes an issue, you can add something like the following to your commit message (usually on the 3rd line):
In that case the referenced issue will be closed when it is merged to master. Make sure you don't mistype the issue number though ;-) |
|
Perfect, thanks for confirming @tessus, and thanks for the PR @nathanleiby! |
scoroi
pushed a commit
to scoroi/joplin
that referenced
this pull request
Nov 10, 2019
…or hidden (laurent22#1940) addresses issue: laurent22#1896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue: #1896
editor visible, preview visible
editor visible, preview NOT visible
editor NOT visible, preview visible (NEW BEHAVIOR)
