Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #11028: Accessibility: Fix sidebar broken in right-to-left mode, improve screen reader accessibility #11056

Merged
merged 15 commits into from
Sep 16, 2024
Merged

Mobile: Fixes #11028: Accessibility: Fix sidebar broken in right-to-left mode, improve screen reader accessibility #11056

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
831983d
Mobile: Improve sidemenu accessibility
personalizedrefrigerator Sep 15, 2024
97e062a
Improve RTL handling, refactoring
personalizedrefrigerator Sep 15, 2024
34b16d7
Refactoring
personalizedrefrigerator Sep 15, 2024
c7acbe2
Make menu style closer to original
personalizedrefrigerator Sep 15, 2024
24e4ed2
Avoid animations when reduceMotion is enabled
personalizedrefrigerator Sep 15, 2024
80090a1
Remove unused dependency
personalizedrefrigerator Sep 15, 2024
9528570
Remove now-unnecessary inert={isHidden}
personalizedrefrigerator Sep 15, 2024
7d9e262
Fix sidemenu content can't be inspected on iOS
personalizedrefrigerator Sep 15, 2024
3cb4a90
Remove unused sideMenuOpenPercent state
personalizedrefrigerator Sep 15, 2024
0939b5d
Change sidemenu styles, trying to fix animation sometimes doing notin…
personalizedrefrigerator Sep 15, 2024
5712a9c
Decrease animation duration
personalizedrefrigerator Sep 15, 2024
8ea4552
Change easing function
personalizedrefrigerator Sep 15, 2024
3248605
Improve focus change handling & refactor accessibility announcements
personalizedrefrigerator Sep 16, 2024
a1751a0
Improve commenting
personalizedrefrigerator Sep 16, 2024
d48c997
Refactoring: Rename openMenuOffset to menuWidth
personalizedrefrigerator Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Decrease animation duration
  • Loading branch information
@personalizedrefrigerator
personalizedrefrigerator committed Sep 15, 2024
commit 5712a9ca8e2e5b90d68f2cb4b76c921a1d848ff8
2 changes: 1 addition & 1 deletion packages/app-mobile/components/SideMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const useAnimations = ({ openMenuOffset, isLeftMenu, open }: UseAnimationsProps)
const updateMenuPosition = useCallback(() => {
const baseAnimationProps = {
easing: Easing.ease,
duration: reduceMotionEnabledRef.current ? 0 : 300,
duration: reduceMotionEnabledRef.current ? 0 : 200,
useNativeDriver: true,
};
setIsAnimating(true);
Expand Down