Android: Fixes #10681: Fix Dropbox sync for certain device languages #10759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
laurent22
reviewed
Jul 17, 2024
| @@ -0,0 +1,115 @@ | |||
| diff --git a/android/src/main/java/com/RNFetchBlob/RNFetchBlobConfig.java b/android/src/main/java/com/RNFetchBlob/RNFetchBlobConfig.java | |||
There was a problem hiding this comment.
Thanks for fixing this! Could you please add a comment at the top explaining what the patch is for? I think you can add comments by prefixing them with #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request should fix #10681 by patching
rn-fetch-blob. Previously,rn-fetch-blobused the user-set locale to lower-case strings, including all headers sent with HTTP requests. This caused issues with the Turkish language, where the lower case form ofIis noti.Notes:
rn-fetch-blob, rather than migrates to a maintained alternative. See Android 14 tab jopplin app not sync via dropbox #10681 (comment) for details.react-native-blob-utilfork.Testing plan
On Android 13: