-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent syntax highlighting colors in themes #3269
Comments
The issue I submitted is specifically regarding syntax highlighting in the editor not matching the official theme colors. I think you are asking why the text is black in the viewer pane which is unrelated to my issue. I assume you are using solarized dark? I don't have the same issue. You should open your own issue with your details. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions. |
Not fixed yet as far as I know. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions. |
Still an issue. |
This should have been fixed by #3703. If not feel free to drop a comment and I'll re-open this. (Please wait for the next release). |
This is a continuation of #2883 since that issue has been closed and the fix caused other issues.
Example with "Dark" theme
Syntax highlighting works as expected
"Solarized Dark" theme
Since the changes in the latest version of Joplin, it looks like the colors from the "dark" theme was used for solarized. This changed the color of inline code from blue to yellow for instance. Technically syntax highlighting is added to everything now but don't think these are the solarized theme colors. It's a strange hybrid now.
Same text in gedit with solarized dark theme for comparison:
Note that inline code is blue (like it was in the previous Joplin version).
"Solarized Light" theme
This is closer to the solarized colors but the list could use a bit more color as it doesn't stand out from the regular text. Furthermore, solarized light is the companion to solarized dark and the syntax highlighting colors should actually be similar between the two. Right now there is no consistency.
Same text in gedit with solarized light theme for comparison:
"Dracula" theme
I'm not as familiar with this theme but I think the colors are missing/wrong for this as well.
Same text in VS Code with the official Dracula theme:
"Nord" theme
I'm also not familiar with this theme but it looks like it is using the same colors as solarized light currently.
Same text in VS Code with the Nord theme:
#3236 Covers the issues with the Joplin Nord theme in more detail.
Environment
Joplin version: 1.0.216
Platform: Linux
OS specifics: Solus 4.1
The text was updated successfully, but these errors were encountered: