Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent syntax highlighting colors in themes #3269

Closed
shbach opened this issue May 25, 2020 · 7 comments
Closed

Inconsistent syntax highlighting colors in themes #3269

shbach opened this issue May 25, 2020 · 7 comments

Comments

@shbach
Copy link

shbach commented May 25, 2020

This is a continuation of #2883 since that issue has been closed and the fix caused other issues.

Example with "Dark" theme

image
Syntax highlighting works as expected

"Solarized Dark" theme

image
Since the changes in the latest version of Joplin, it looks like the colors from the "dark" theme was used for solarized. This changed the color of inline code from blue to yellow for instance. Technically syntax highlighting is added to everything now but don't think these are the solarized theme colors. It's a strange hybrid now.

Same text in gedit with solarized dark theme for comparison:
image
Note that inline code is blue (like it was in the previous Joplin version).

"Solarized Light" theme

image
This is closer to the solarized colors but the list could use a bit more color as it doesn't stand out from the regular text. Furthermore, solarized light is the companion to solarized dark and the syntax highlighting colors should actually be similar between the two. Right now there is no consistency.

Same text in gedit with solarized light theme for comparison:
image

"Dracula" theme

image
I'm not as familiar with this theme but I think the colors are missing/wrong for this as well.

Same text in VS Code with the official Dracula theme:
image

"Nord" theme

image
I'm also not familiar with this theme but it looks like it is using the same colors as solarized light currently.

Same text in VS Code with the Nord theme:
image

#3236 Covers the issues with the Joplin Nord theme in more detail.

Environment

Joplin version: 1.0.216
Platform: Linux
OS specifics: Solus 4.1

@shbach shbach added the bug It's a bug label May 25, 2020
@shbach shbach changed the title Inconsistent syntax highlighting in themes Inconsistent syntax highlighting colors in themes May 25, 2020
@laurent22 laurent22 removed the bug It's a bug label May 25, 2020
@xarthurx
Copy link

xarthurx commented Jun 9, 2020

image

Any idea why all my dark theme will not highlight the render the text?
I thought this is an general issue of the software and are about to submit an issue, until I saw your screenshot here.

@shbach
Copy link
Author

shbach commented Jun 10, 2020

image

Any idea why all my dark theme will not highlight the render the text?
I thought this is an general issue of the software and are about to submit an issue, until I saw your screenshot here.

The issue I submitted is specifically regarding syntax highlighting in the editor not matching the official theme colors. I think you are asking why the text is black in the viewer pane which is unrelated to my issue. I assume you are using solarized dark? I don't have the same issue. You should open your own issue with your details.

image

@stale
Copy link

stale bot commented Jul 10, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Jul 10, 2020
@shbach
Copy link
Author

shbach commented Jul 10, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Not fixed yet as far as I know.

@stale stale bot removed the stale An issue that hasn't been active for a while... label Jul 10, 2020
@stale
Copy link

stale bot commented Aug 9, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Aug 9, 2020
@shbach
Copy link
Author

shbach commented Aug 9, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Still an issue.

@stale stale bot removed the stale An issue that hasn't been active for a while... label Aug 9, 2020
@CalebJohn
Copy link
Collaborator

This should have been fixed by #3703. If not feel free to drop a comment and I'll re-open this. (Please wait for the next release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants